Conversation
|
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
|
One or more of the following people are relevant to this code: |
frankharkins
left a comment
There was a problem hiding this comment.
Thank you!
For the links in the API docs, we'll need to add the redirects to scripts/config/external-redirects.ts, otherwise these changes will be discarded when we next regenerate the docs from source.
The format is:
"old":
"new",E.g.
documentation/scripts/config/external-redirects.ts
Lines 38 to 39 in 2140419
Co-authored-by: Frank Harkins <[email protected]>
Even though the changes will be made in the API docs themselves? |
Yep: We store the original API docs HTML in Box and sometimes re-run the HTML -> markdown pipeline to fix bugs. When this happens, your fixes will be overwritten by the pipeline with the original links. The |
|
@frankharkins what should we do about links that are broken in historical API documents but don't exist in more recent documents? For example, qaiskit-ibm-runtime/0.40/qiskit-runtime-service links to https://auth.quantum.ibm.com/api. That API no longer exists and the link was just deleted from the later versions. |
arnaucasau
left a comment
There was a problem hiding this comment.
Thanks for working on this, Becky!!
| * The `channel_strategy` parameter in `QiskitRuntimeService` has been removed. To continue using Q-CTRL in your workflow, please explore the following options: | ||
|
|
||
| > * If your organization has an existing IBM Quantum Premium Plan instance: migrate to the Q-CTRL Performance Management Function, found in the [Qiskit Functions Catalog](https://quantum.ibm.com/functions). | ||
| > * To continue using Qiskit Runtime with IBM Cloud: migrate to Q-CTRL Fire Opal, the same performance management product accessible directly through Q-CTRL. You can [connect your IBM Cloud API key and Qiskit Runtime CRN](https://docs.q-ctrl.com/fire-opal/discover/hardware-providers/how-to-authenticate-with-ibm-credentials) to Fire Opal. ([1966](https://github.com/Qiskit/qiskit-ibm-runtime/pull/1966)) |
There was a problem hiding this comment.
This link needs to be fixed in the runtime repo (main branch and stable/0.45):
There was a problem hiding this comment.
This link needs to be fixed in the runtime repo
Jessie said to just ignore it, since it's in a really old release note. I'll add to the Ignore file.
There was a problem hiding this comment.
Unfortunately, we can't ignore the issue because it's in the release notes. Our script regenerates the whole release note file with each version, so we would revert the change in the future if it's not fixed.
We can only ignore issues with historical versions if it's in a page different than the release notes :(
There was a problem hiding this comment.
In my opinion we should fix it on the runtime repo and remove the redirect in external-redirects.ts given that it won't be necessary anymore
I think if a link has no replacement, it's OK for it to be broken in a historical version. These are archives after all and it might even be helpful for a user to know that the API isn't available any more. Maybe just update the comment to explain we're not going to fix them. |
I updated the comment in the Ignore.ts file to explain why we're leaving the links that don't have a replacement as-is in the old API docs. I also added the redirects listed to the external-redirects file. |
scripts/config/external-redirects.ts
Outdated
| "https://docs.q-ctrl.com/fire-opal/discover/hardware-providers/how-to-authenticate-with-ibm-credentials": | ||
| "https://docs.q-ctrl.com/fire-opal/discover/hardware-providers/how-to-migrate-from-performance-management-on-ibm-cloud", |
There was a problem hiding this comment.
We can remove it if we do https://github.com/Qiskit/documentation/pull/4506/changes#r2758072445
| // but they will never be fixed in the old API docs. We decided to leave these links as-is for archival purposes. | ||
| "https://github.com/Qiskit/ibm-quantum-schemas/blob/main/schemas/backend_status_schema.json", | ||
| "https://github.com/Qiskit/ibm-quantum-schemas/blob/main/schemas/default_pulse_configuration_schema.json", | ||
| "https://docs.q-ctrl.com/fire-opal/discover/hardware-providers/how-to-authenticate-with-ibm-credentials", |
There was a problem hiding this comment.
Do we need this link to be ignored now? I think we can remove it if it only appears in the qiskit-ibm-runtime release notes
Related to #4336